Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17014 Use special brackets to distinguish fallback values based on codes #3919

Closed
wants to merge 1 commit into from
Closed

CLDR-17014 Use special brackets to distinguish fallback values based on codes #3919

wants to merge 1 commit into from

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented Jul 30, 2024

-New CONSTRUCTED_VALUE_PREFIX, CONSTRUCTED_VALUE_SUFFIX, makeConstructedValue

CLDR-17014

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@btangmu
CLDR-17014 Use special brackets to distinguish fallback values based …
60e95e7 
…on codes

-New CONSTRUCTED_VALUE_PREFIX, CONSTRUCTED_VALUE_SUFFIX, makeConstructedValue
@btangmu
Copy link
Member Author

btangmu commented Jul 30, 2024 •
edited
Loading

There are a few test failures like

Test4528
Error:  (TestExampleGenerator.java:957)  Error: : specifics: expected "〖❬123.456,79 ❭BMD〗", got "〖❬123.456,79 ❭⟦BMD⟧〗"

and

TestLocaleDisplay
Warning:  (TestLocale.java:514)  Warning: 
Use -v to get samples for tests

Error:  (TestLocale.java:587)  Error: : en; en-u-cu-chf: expected "English (Currency: CHF)", got "English (Currency: ⟦CHF⟧)"

Error:  (TestLocale.java:587)  Error: : en; en-u-tz-uslax: expected "English (Time Zone: Los Angeles Time)", got "English (Time Zone: ⟦Los Angeles⟧ Time)"

Error:  (TestLocale.java:587)  Error: : af; zh-Hans-fonipa: expected "Chinees (Vereenvoudig, FONIPA)", got "Chinees (Vereenvoudig, ⟦FONIPA⟧)"

Evidently the "fallback" values are treated as correct, rather than as placeholders for missing data, for some paths, so it might be necessary to distinguish two kinds of path that currently both rely on constructedItems...?

Or, maybe not. The "BMD" example above appears to depend on this path:

//ldml/numbers/currencies/currency[@type="BMD"]/symbol

https://st.unicode.org/cldr-apps/v#/it/C_NAmerica/6cc0bc4c231d3996

Currently the winning value "BMD" is shown as an "untranslated code" -- that is, inherited. If the code changes to "⟦BMD⟧", then the value should change to "BMD" and it should be present in it.xml. Currently it.xml has:

			<currency type="BMD">
				<displayName>dollaro delle Bermuda</displayName>
				<displayName count="one">dollaro delle Bermuda</displayName>
				<displayName count="other">dollari delle Bermuda</displayName>
				<symbol>↑↑↑</symbol>

That "↑↑↑" should change to "BMD". Then the test will pass...

@srl295
Copy link
Member

srl295 commented Jul 31, 2024

I'm not sure about this approach, and I added comments on the ticket https://unicode-org.atlassian.net/browse/CLDR-17014

@btangmu
Copy link
Member Author

btangmu commented Jan 17, 2025

Instead of special brackets, we're now looking at simply having no fallback values; that can be implemented using extra paths, see #4254

@btangmu btangmu closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@btangmu btangmu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@btangmu @srl295